-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3771: register_commands.py to handle generic scalar type #3772
Closes #3771: register_commands.py to handle generic scalar type #3772
Conversation
37c941b
to
56f4364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the .configs/
files (used for CI) will also need the new "scalar" parameter class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!! Thanks so much amanda! I'm going to go ahead and merge this and I'll add a quick PR to add to the .configs
for the CI like jeremiah said
def unpack_scalar_arg_with_generic(arg_name, array_count): | ||
""" | ||
Generate the code to unpack a scalar argument | ||
|
||
'scalar_count' is used to generate unique names when | ||
a procedure has multiple array-symbol formals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def unpack_scalar_arg_with_generic(arg_name, array_count): | |
""" | |
Generate the code to unpack a scalar argument | |
'scalar_count' is used to generate unique names when | |
a procedure has multiple array-symbol formals | |
def unpack_scalar_arg_with_generic(arg_name, scalar_count): | |
""" | |
Generate the code to unpack a scalar argument | |
'scalar_count' is used to generate unique names when | |
a procedure has multiple scalar-symbol formals |
Closes #3771: register_commands.py to handle generic scalar type
This PR modifies register_commands.py to handle arguments that have a generic scalar type. The following example demonstrates the new functionality.
When the following is compiled within arkouda:
The following will work in arkouda: